K8SPSMDB-1433 Fixed the option to specify vault secret for #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the documentation for data-at-rest encryption in Percona Operator for MongoDB, focusing on better flow and readability. The changes restructure the content to provide clearer explanations and a more logical progression through the setup process.
- Rewrote the introduction to better explain data-at-rest encryption and its two-tiered architecture
- Enhanced HashiCorp Vault integration section with detailed step-by-step instructions and sample outputs
- Improved formatting and organization with better section headings and structure
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
docs/encryption.md
Outdated
| 3. Retrieve the Pod name where Vault is running: | ||
|
|
||
| ```{.bash data-prompt="$" } | ||
| $(kubectl -n $NAMESPACE get pod -l app.kubernetes.io/name=vault -o jsonpath='{.items[0].metadata.name}') |
There was a problem hiding this comment.
The command is missing variable assignment. It should be VAULT_POD_NAME=$(kubectl...) to store the pod name for later use.
Suggested change
| $(kubectl -n $NAMESPACE get pod -l app.kubernetes.io/name=vault -o jsonpath='{.items[0].metadata.name}') | |
| VAULT_POD_NAME=$(kubectl -n $NAMESPACE get pod -l app.kubernetes.io/name=vault -o jsonpath='{.items[0].metadata.name}') |
Copilot uses AI. Check for mistakes.
Updated the doc to improve the flow and readability
nastena1606
force-pushed
the
K8SPSMDB-1433-Fix-vault-secret-name
branch
from
e14ca1a to
9403fd0
Compare
egegunes
approved these changes
Sep 22, 2025
Co-authored-by: Copilot <[email protected]>
nastena1606
added
the
pending release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the doc to improve the flow and readability