-
Notifications
You must be signed in to change notification settings - Fork 31
K8SPS-464 set crVersion #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmarukovich please fix conflicts
reconciler := &PerconaServerMySQLReconciler{Client: k8sClient} | ||
err = reconciler.setCRVersion(ctx, cr) | ||
Expect(err).To(HaveOccurred()) | ||
Expect(err.Error()).To(ContainSubstring("patch CR")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be better to explicitly check that error is not found, it might be another error and we might miss it
please fix conflicts |
commit: 431da75 |
CHANGE DESCRIPTION
Problem:
We need to set crVersion if it doesn't set in cr.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability