This repository was archived by the owner on Jun 21, 2022. It is now read-only.
PMM-7806: compatibility with upstream pg_exporter #1132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 24, 2022
tshcherban
approved these changes
May 25, 2022
tshcherban
reviewed
May 25, 2022
models/agent_model.go
Outdated
|
|
||
| u := &url.URL{ | ||
| Scheme: "postgres", | ||
| Scheme: "postgresql", |
There was a problem hiding this comment.
youll need to adjust tests, some of them expects postgres
There was a problem hiding this comment.
BTW, why it was changed? postgres is valid scheme https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNSTRING
There was a problem hiding this comment.
it no longer valid DSN in pg exporter
percona-csalguero
approved these changes
May 25, 2022
artemgavrilov
approved these changes
May 25, 2022
tshcherban
approved these changes
May 31, 2022
artemgavrilov
approved these changes
Jun 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #1132 +/- ##
==========================================
+ Coverage 48.67% 48.97% +0.29%
==========================================
Files 181 182 +1
Lines 21264 21327 +63
==========================================
+ Hits 10351 10444 +93
+ Misses 9775 9727 -48
- Partials 1138 1156 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-7806
Feature Build:
Related PRs: