bug: diff code blocks used but not supported (#4156) #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's go with |
|
Question on the css selectors - are .token.inserted and .token.deleted selectors in src/styles/components/_code.scss used by any other elements or are they there only for the diff blocks and just previously unused? |
Looks good. Here's a list of pages found to have `class="` then the word `token` followed by the word `inserted` then followed by a closing `"`. The screenshot also includes the regex I used. Looking at these pages, these have code blocks we'd expect to have these selectors.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves ionic-team#4156