fcinfo: fix incorrect length set in unsafe code #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to `std::slice::from_raw_parts`, the len argument is the number of elements, not the number of bytes.
thomcc
approved these changes
Jul 5, 2023
|
macOS failure is unrelated. |
|
Rerunning the tests, hopefully without spurious errors this time. |
workingjubilee
approved these changes
Jul 5, 2023
eeeebbbbrrrr
pushed a commit
that referenced
this pull request
Jul 14, 2023
according to `std::slice::from_raw_parts`, the len argument is the number of elements, not the number of bytes.
eeeebbbbrrrr
added a commit
that referenced
this pull request
Sep 5, 2023
This is the final release of v0.10.0. Thanks everyone for the beta testing, pull requests, issues, and patience. As always, install `cargo-pgrx` with `cargo install cargo-pgrx --locked` and update your extension Cargo.toml files to use the `0.10.0` pgrx dependencies. This release includes support for Postgres 16RC1. Support for the previous betas has been removed. As such, a fresh `cargo pgrx init` is required. ## What's Changed Since v0.10.0-beta.4 * Fix `GetMemoryChunkContext` port by @workingjubilee in #1273 * Better error messages when `pg_config` isn't found. by @eeeebbbbrrrr in #1271 * Make `PostgresHash` also need `Eq` by @workingjubilee in #1264 * Memoize git hash and extension metadata by @levkk in #1274 * move to pg16rc1 by @eeeebbbbrrrr in #1276 * Fix bgworker template up to 0.10.0-beta.4 by @workingjubilee in #1270 ## New Contributors * @levkk made their first contribution in #1274 **Changelog**: v0.10.0-beta.4...v0.10.0 --- v0.10.0's full set of changes throughout the entire beta period are: * Postgres 16beta1 Support by @eeeebbbbrrrr in #1169 * Support building against macOS universal binaries by @clowder in #1166 * list specific versions in feature gates by @eeeebbbbrrrr in #1175 * Fix bug with converting a `pg_sys::Datum` into a `pgrx::Date` by @eeeebbbbrrrr in #1177 * Fix Arrays with leading nulls by @eeeebbbbrrrr in #1180 * Disable hello_versioned_so test by @workingjubilee in #1192 * doc: fix link broken by @yihong0618 in #1181 * fcinfo: fix incorrect length set in unsafe code by @Sasasu in #1190 * update to pg16beta2 support by @eeeebbbbrrrr in #1188 * Array-walking is aligned by @workingjubilee in #1191 * Implement PGRXSharedMemory for Deque by @feikesteenbergen in #1170 * Include security labels header by @daamien in #1189 * Fixes macos-11 tests by @BradyBonnette in #1197 * Pgcentralfoundation updates again by @eeeebbbbrrrr in #1200 * Update version to 0.10.0-beta.0 by @eeeebbbbrrrr in #1201 * Testing help by @eeeebbbbrrrr in #1203 * Type testability cleanup by @eeeebbbbrrrr in #1204 * Try to smartly propagate fs errors by @workingjubilee in #1186 * Fix issue #1209 by @eeeebbbbrrrr in #1210 * Type roundtrip tests by @eeeebbbbrrrr in #1185 * Update version to 0.10.0-beta.1 by @eeeebbbbrrrr in #1213 * Add a workaround for the pg16/homebrew/icu4c situation by @thomcc in #1206 * Add security policy by @johnrballard in #1207 * `AnyNumeric` is no longer backed by Postgres-allocated memory by @eeeebbbbrrrr in #1216 * Modularize pgrx::spi by @workingjubilee in #1219 * Stop SpiClient soundness from regressing by @workingjubilee in #1214 * Add foreign table headers by @workingjubilee in #1226 * Modularize the interior of pgrx-pg-sys by @workingjubilee in #1227 * Initial valgrind support by @thomcc in #1218 * Add support for handling SIGINT and SIGCHLD from bgworker by @JelteF in #1229 * Ignores UI tests for MUSL environments by @BradyBonnette in #1235 * Add a env flag that can be set to skip `#[pg_test]`-generated tests. by @thomcc in #1239 * Fix issue #1076: Properly handle dependency graph of `Result<T, _>` by @eeeebbbbrrrr in #1241 * Cleanup the error when cargo-pgrx version doesn't match Cargo.toml by @eeeebbbbrrrr in #1240 * Add operator and cache related api by @VoVAllen in #1242 * Addresses cargo-pgrx error reporting by @BradyBonnette in #1238 * Update version to 0.10.0-beta.2 by @eeeebbbbrrrr in #1244 * Bump cargo-metadata and clap-cargo by @thomcc in #1246 * Derive Clone for Inet by @JelteF in #1251 * Correct docs for datetime `From` impls by @workingjubilee in #1253 * Only enable line tables for profile.dev by @thomcc in #1249 * Remove references to master branch by @thomcc in #1243 * Ensure bindgen gets all the `cppflags` it needs (on macOS, anyway) by @thomcc in #1247 * update for pg16beta3 support by @eeeebbbbrrrr in #1254 * Update version to 0.10.0-beta.3 by @eeeebbbbrrrr in #1255 * Add proptest support by @workingjubilee in #1258 * Misc reformatting and typo fixes by @workingjubilee in #1260 * spi: simplify (optimize?) Datum preparation by @vrmiguel in #1256 * Assume commutation when deriving PostgresEq by @workingjubilee in #1261 * Demand Ord for PostgresOrd by @workingjubilee in #1262 * Fix pgrx install causing postgresql coredump by @Sasasu in #1263 * Update version to 0.10.0-beta.4 by @workingjubilee in #1267 ## New Contributors * @clowder made their first contribution in #1166 * @yihong0618 made their first contribution in #1181 * @Sasasu made their first contribution in #1190 * @daamien made their first contribution in #1189 * @johnrballard made their first contribution in #1207 * @VoVAllen made their first contribution in #1242 * @vrmiguel made their first contribution in #1256 **Full Changelog**: v0.9.8...v0.10.0
usamoi
pushed a commit
to tensorchord/pgrx
that referenced
this pull request
Mar 6, 2025
…1190) according to `std::slice::from_raw_parts`, the len argument is the number of elements, not the number of bytes.
usamoi
pushed a commit
to tensorchord/pgrx
that referenced
this pull request
Mar 6, 2025
This is the final release of v0.10.0. Thanks everyone for the beta testing, pull requests, issues, and patience. As always, install `cargo-pgrx` with `cargo install cargo-pgrx --locked` and update your extension Cargo.toml files to use the `0.10.0` pgrx dependencies. This release includes support for Postgres 16RC1. Support for the previous betas has been removed. As such, a fresh `cargo pgrx init` is required. ## What's Changed Since v0.10.0-beta.4 * Fix `GetMemoryChunkContext` port by @workingjubilee in pgcentralfoundation#1273 * Better error messages when `pg_config` isn't found. by @eeeebbbbrrrr in pgcentralfoundation#1271 * Make `PostgresHash` also need `Eq` by @workingjubilee in pgcentralfoundation#1264 * Memoize git hash and extension metadata by @levkk in pgcentralfoundation#1274 * move to pg16rc1 by @eeeebbbbrrrr in pgcentralfoundation#1276 * Fix bgworker template up to 0.10.0-beta.4 by @workingjubilee in pgcentralfoundation#1270 ## New Contributors * @levkk made their first contribution in pgcentralfoundation#1274 **Changelog**: pgcentralfoundation/pgrx@v0.10.0-beta.4...v0.10.0 --- v0.10.0's full set of changes throughout the entire beta period are: * Postgres 16beta1 Support by @eeeebbbbrrrr in pgcentralfoundation#1169 * Support building against macOS universal binaries by @clowder in pgcentralfoundation#1166 * list specific versions in feature gates by @eeeebbbbrrrr in pgcentralfoundation#1175 * Fix bug with converting a `pg_sys::Datum` into a `pgrx::Date` by @eeeebbbbrrrr in pgcentralfoundation#1177 * Fix Arrays with leading nulls by @eeeebbbbrrrr in pgcentralfoundation#1180 * Disable hello_versioned_so test by @workingjubilee in pgcentralfoundation#1192 * doc: fix link broken by @yihong0618 in pgcentralfoundation#1181 * fcinfo: fix incorrect length set in unsafe code by @Sasasu in pgcentralfoundation#1190 * update to pg16beta2 support by @eeeebbbbrrrr in pgcentralfoundation#1188 * Array-walking is aligned by @workingjubilee in pgcentralfoundation#1191 * Implement PGRXSharedMemory for Deque by @feikesteenbergen in pgcentralfoundation#1170 * Include security labels header by @daamien in pgcentralfoundation#1189 * Fixes macos-11 tests by @BradyBonnette in pgcentralfoundation#1197 * Pgcentralfoundation updates again by @eeeebbbbrrrr in pgcentralfoundation#1200 * Update version to 0.10.0-beta.0 by @eeeebbbbrrrr in pgcentralfoundation#1201 * Testing help by @eeeebbbbrrrr in pgcentralfoundation#1203 * Type testability cleanup by @eeeebbbbrrrr in pgcentralfoundation#1204 * Try to smartly propagate fs errors by @workingjubilee in pgcentralfoundation#1186 * Fix issue pgcentralfoundation#1209 by @eeeebbbbrrrr in pgcentralfoundation#1210 * Type roundtrip tests by @eeeebbbbrrrr in pgcentralfoundation#1185 * Update version to 0.10.0-beta.1 by @eeeebbbbrrrr in pgcentralfoundation#1213 * Add a workaround for the pg16/homebrew/icu4c situation by @thomcc in pgcentralfoundation#1206 * Add security policy by @johnrballard in pgcentralfoundation#1207 * `AnyNumeric` is no longer backed by Postgres-allocated memory by @eeeebbbbrrrr in pgcentralfoundation#1216 * Modularize pgrx::spi by @workingjubilee in pgcentralfoundation#1219 * Stop SpiClient soundness from regressing by @workingjubilee in pgcentralfoundation#1214 * Add foreign table headers by @workingjubilee in pgcentralfoundation#1226 * Modularize the interior of pgrx-pg-sys by @workingjubilee in pgcentralfoundation#1227 * Initial valgrind support by @thomcc in pgcentralfoundation#1218 * Add support for handling SIGINT and SIGCHLD from bgworker by @JelteF in pgcentralfoundation#1229 * Ignores UI tests for MUSL environments by @BradyBonnette in pgcentralfoundation#1235 * Add a env flag that can be set to skip `#[pg_test]`-generated tests. by @thomcc in pgcentralfoundation#1239 * Fix issue pgcentralfoundation#1076: Properly handle dependency graph of `Result<T, _>` by @eeeebbbbrrrr in pgcentralfoundation#1241 * Cleanup the error when cargo-pgrx version doesn't match Cargo.toml by @eeeebbbbrrrr in pgcentralfoundation#1240 * Add operator and cache related api by @VoVAllen in pgcentralfoundation#1242 * Addresses cargo-pgrx error reporting by @BradyBonnette in pgcentralfoundation#1238 * Update version to 0.10.0-beta.2 by @eeeebbbbrrrr in pgcentralfoundation#1244 * Bump cargo-metadata and clap-cargo by @thomcc in pgcentralfoundation#1246 * Derive Clone for Inet by @JelteF in pgcentralfoundation#1251 * Correct docs for datetime `From` impls by @workingjubilee in pgcentralfoundation#1253 * Only enable line tables for profile.dev by @thomcc in pgcentralfoundation#1249 * Remove references to master branch by @thomcc in pgcentralfoundation#1243 * Ensure bindgen gets all the `cppflags` it needs (on macOS, anyway) by @thomcc in pgcentralfoundation#1247 * update for pg16beta3 support by @eeeebbbbrrrr in pgcentralfoundation#1254 * Update version to 0.10.0-beta.3 by @eeeebbbbrrrr in pgcentralfoundation#1255 * Add proptest support by @workingjubilee in pgcentralfoundation#1258 * Misc reformatting and typo fixes by @workingjubilee in pgcentralfoundation#1260 * spi: simplify (optimize?) Datum preparation by @vrmiguel in pgcentralfoundation#1256 * Assume commutation when deriving PostgresEq by @workingjubilee in pgcentralfoundation#1261 * Demand Ord for PostgresOrd by @workingjubilee in pgcentralfoundation#1262 * Fix pgrx install causing postgresql coredump by @Sasasu in pgcentralfoundation#1263 * Update version to 0.10.0-beta.4 by @workingjubilee in pgcentralfoundation#1267 ## New Contributors * @clowder made their first contribution in pgcentralfoundation#1166 * @yihong0618 made their first contribution in pgcentralfoundation#1181 * @Sasasu made their first contribution in pgcentralfoundation#1190 * @daamien made their first contribution in pgcentralfoundation#1189 * @johnrballard made their first contribution in pgcentralfoundation#1207 * @VoVAllen made their first contribution in pgcentralfoundation#1242 * @vrmiguel made their first contribution in pgcentralfoundation#1256 **Full Changelog**: pgcentralfoundation/pgrx@v0.9.8...v0.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to
std::slice::from_raw_parts, the len argument is the number of elements, not the number of bytes.