Move ext-sockets from "suggest" to "require" #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #608 Please see this comment as to why this is not going to be considered a breaking change: #608 (comment)
lukebakken
force-pushed
the
require-sockets-2.8.1
branch
from
91359fe to
d24fe09
Compare
hairyhum
approved these changes
Oct 25, 2018
|
Thank you @hairyhum |
williamespindola
added a commit
to MemedDev/docker-php
that referenced
this pull request
Dec 18, 2018
php-amqplib require this extension php-amqplib/php-amqplib#610
williamespindola
added a commit
to MemedDev/docker-php
that referenced
this pull request
Dec 18, 2018
php-amqplib requires this extension php-amqplib/php-amqplib#610
|
@lukebakken, I'm totally disagree with you, connection to AMQP server can be initiated with both Stream and Socket. While Stream don't have additional php module requirements and is listed in all examples as default engine - adding Socket to dependencies looks strange as for me, because you may ever not need it. Better solution I think is to split Socket connection library into separate package which will depends on php-amqplib/php-amqplib |
|
I'm happy to evaluate suggestions if they come in the form of pull requests. |
kratkyzobak
pushed a commit
to kratkyzobak/php-amqplib
that referenced
this pull request
Feb 9, 2024
….8.1 Move ext-sockets from "suggest" to "require"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #608
Please see this comment as to why this is not going to be considered a breaking change:
#608 (comment)