CategoryService.add(): change return type from UrlEntityDto to String.

Addressed to #440

No functional changes.

Author: php-coder

src/main/java/ru/mystamps/web/controller/CategoryController.java

@@ -45,7 +45,6 @@
 import ru.mystamps.web.controller.converter.annotation.CurrentUser;
 import ru.mystamps.web.dao.dto.LinkEntityDto;
 import ru.mystamps.web.dao.dto.SeriesInfoDto;
-import ru.mystamps.web.dao.dto.UrlEntityDto;
 import ru.mystamps.web.model.AddCategoryForm;
 import ru.mystamps.web.service.CategoryService;
 import ru.mystamps.web.service.SeriesService;
@@ -83,11 +82,11 @@ public String processInput(
 			return null;
 		}
 
-		UrlEntityDto categoryUrl = categoryService.add(form, currentUserId);
+		String slug = categoryService.add(form, currentUserId);
 
 		redirectAttributes.addFlashAttribute("justAddedCategory", true);
 
-		return redirectTo(Url.INFO_CATEGORY_PAGE, categoryUrl.getSlug());
+		return redirectTo(Url.INFO_CATEGORY_PAGE, slug);
 	}
 
 	@RequestMapping(Url.INFO_CATEGORY_PAGE)

src/main/java/ru/mystamps/web/service/CategoryService.java

@@ -21,11 +21,10 @@
 import java.util.List;
 
 import ru.mystamps.web.dao.dto.LinkEntityDto;
-import ru.mystamps.web.dao.dto.UrlEntityDto;
 import ru.mystamps.web.service.dto.AddCategoryDto;
 
 public interface CategoryService {
-	UrlEntityDto add(AddCategoryDto dto, Integer userId);
+	String add(AddCategoryDto dto, Integer userId);
 	List<LinkEntityDto> findAllAsLinkEntities(String lang);
 	LinkEntityDto findOneAsLinkEntity(String slug, String lang);
 	long countAll();

src/main/java/ru/mystamps/web/service/CategoryServiceImpl.java

@@ -51,7 +51,7 @@ public class CategoryServiceImpl implements CategoryService {
 	@Override
 	@Transactional
 	@PreAuthorize(HasAuthority.CREATE_CATEGORY)
-	public UrlEntityDto add(AddCategoryDto dto, Integer userId) {
+	public String add(AddCategoryDto dto, Integer userId) {
 		Validate.isTrue(dto != null, "DTO must be non null");
 		Validate.isTrue(dto.getName() != null, "Category name in English must be non null");
 		Validate.isTrue(dto.getNameRu() != null, "Category name in Russian must be non null");
@@ -78,7 +78,7 @@ public UrlEntityDto add(AddCategoryDto dto, Integer userId) {
 		Integer id = categoryDao.add(category);
 		LOG.info("Category #{} has been created ({})", id, category);
 
-		return new UrlEntityDto(id, slug);
+		return slug;
 	}
 
 	@Override

src/test/groovy/ru/mystamps/web/service/CategoryServiceImplTest.groovy

@@ -24,7 +24,6 @@ import ru.mystamps.web.dao.CategoryDao
 import ru.mystamps.web.dao.dto.AddCategoryDbDto
 import ru.mystamps.web.model.AddCategoryForm
 import ru.mystamps.web.dao.dto.LinkEntityDto
-import ru.mystamps.web.dao.dto.UrlEntityDto
 import ru.mystamps.web.tests.DateUtils
 import ru.mystamps.web.util.SlugUtils
 
@@ -87,12 +86,10 @@ class CategoryServiceImplTest extends Specification {
 			String expectedSlug = 'example-category'
 		and:
 			categoryDao.add(_ as AddCategoryDbDto) >> expectedId
-		and:
-			UrlEntityDto expected = new UrlEntityDto(expectedId, expectedSlug)
 		when:
-			UrlEntityDto actual = service.add(form, userId)
+			String actualSlug = service.add(form, userId)
 		then:
-			actual == expected
+			actualSlug == expectedSlug
 	}
 
 	def "add() should pass English category name to dao"() {