Skip to content

Replace usage of UrlEntityDto by String #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6 tasks done
php-coder opened this issue Aug 15, 2016 · 1 comment
Closed
6 tasks done

Replace usage of UrlEntityDto by String #440

php-coder opened this issue Aug 15, 2016 · 1 comment
Assignees
@php-coder
Labels
refactoring
Milestone
0.4

Comments

@php-coder
Copy link
Owner

php-coder commented Aug 15, 2016 •
edited
Loading

UrlEntityDto holds id and slug members that are used for building URLs. After migration to URLs with slugs (#205, #206, #207) we don't use id and I think that we can replace UrlEntityDto by String.

The following methods should be updated:

  • CategoryService.add()
  • CountryService.add()
  • CollectionService.addToCollection()
    • CollectionDao.addSeriesToCollection(): replace argument collectionId by collectionSlug
  • CollectionService.removeFromCollection()
    • CollectionDao.removeSeriesFromCollection(): replace argument collectionId by collectionSlug
@php-coder php-coder modified the milestone: next Aug 15, 2016
php-coder added a commit that referenced this issue Sep 17, 2016
@php-coder
CategoryService.add(): change return type from UrlEntityDto to String.
1f15395 
Addressed to #440

No functional changes.
php-coder added a commit that referenced this issue Sep 17, 2016
@php-coder
CountryService.add(): change return type from UrlEntityDto to String.
e174bec 
Addressed to #440

No functional changes.
@php-coder php-coder self-assigned this Sep 17, 2016
@php-coder php-coder modified the milestones: 0.4, next Sep 17, 2016
php-coder added a commit that referenced this issue Sep 19, 2016
@php-coder
CollectionDao.addSeriesToCollection(): replace argument collectionId …
5cc4ba8 
…by collectionSlug.

Addressed to #440

No functional changes.
php-coder added a commit that referenced this issue Sep 19, 2016
@php-coder
CollectionService.addToCollection(): don't return UrlEntityDto.
84bbed6 
Addressed to #440

No functional changes.
cssru pushed a commit to cssru/mystamps that referenced this issue Oct 5, 2016
@php-coder @cssru
CategoryService.add(): change return type from UrlEntityDto to String.
4d6979c 
Addressed to php-coder#440

No functional changes.
cssru pushed a commit to cssru/mystamps that referenced this issue Oct 5, 2016
@php-coder @cssru
CountryService.add(): change return type from UrlEntityDto to String.
a6590ec 
Addressed to php-coder#440

No functional changes.
cssru pushed a commit to cssru/mystamps that referenced this issue Oct 5, 2016
@php-coder @cssru
CollectionDao.addSeriesToCollection(): replace argument collectionId …
d754e7f 
…by collectionSlug.

Addressed to php-coder#440

No functional changes.
cssru pushed a commit to cssru/mystamps that referenced this issue Oct 5, 2016
@php-coder @cssru
CollectionService.addToCollection(): don't return UrlEntityDto.
8583239 
Addressed to php-coder#440

No functional changes.
php-coder added a commit that referenced this issue Oct 19, 2016
@php-coder
CollectionService.removeFromCollection(): don't return UrlEntityDto.
ff8fff5 
Addressed to #440

No functional changes.
@php-coder
Copy link
Owner Author

Done.

@php-coder php-coder mentioned this issue Oct 19, 2016
Closed
php-coder added a commit that referenced this issue Oct 19, 2016
@php-coder
Unbreak removing series from collection.
2a5098c 
Correction for ff8fff5 commit.

Addressed to #440
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
@php-coder @bodom91
CategoryService.add(): change return type from UrlEntityDto to String.
18462d9 
Addressed to php-coder#440

No functional changes.
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
@php-coder @bodom91
CountryService.add(): change return type from UrlEntityDto to String.
f75ee84 
Addressed to php-coder#440

No functional changes.
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
@php-coder @bodom91
CollectionDao.addSeriesToCollection(): replace argument collectionId …
3081d03 
…by collectionSlug.

Addressed to php-coder#440

No functional changes.
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
@php-coder @bodom91
CollectionService.addToCollection(): don't return UrlEntityDto.
65a16a7 
Addressed to php-coder#440

No functional changes.
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
@php-coder @bodom91
CollectionService.removeFromCollection(): don't return UrlEntityDto.
74e368c 
Addressed to php-coder#440

No functional changes.
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
@php-coder @bodom91
Unbreak removing series from collection.
3fac29f 
Correction for ff8fff5 commit.

Addressed to php-coder#440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
refactoring
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@php-coder