Skip to content

Remove support for URLs that were used in past #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Sep 9, 2019 · 1 comment
Closed

Remove support for URLs that were used in past #1120

php-coder opened this issue Sep 9, 2019 · 1 comment
Assignees
@php-coder
Labels
trivial
Milestone
0.4.2

Comments

@php-coder
Copy link
Owner

We should decommission support for URLs that were left for backward compatibility:

$ git grep -i -A1 'backward compatibility'
src/main/java/ru/mystamps/web/feature/account/AccountUrl.java:  // For backward compatibility
src/main/java/ru/mystamps/web/feature/account/AccountUrl.java-  static final String ACTIVATE_ACCOUNT_PAGE_WITH_KEY = "/account/activate/key/{key}";
--
src/main/java/ru/mystamps/web/feature/category/CategoryUrl.java:        // For backward compatibility
src/main/java/ru/mystamps/web/feature/category/CategoryUrl.java-        static final String LIST_CATEGORIES_PAGE       = "/category/list";
--
src/main/java/ru/mystamps/web/feature/collection/CollectionUrl.java:    // For backward compatibility
src/main/java/ru/mystamps/web/feature/collection/CollectionUrl.java-    static final String INFO_COLLECTION_BY_ID_PAGE = "/collection/{id}/{slug}";
--
src/main/java/ru/mystamps/web/feature/country/CountryUrl.java:  // For backward compatibility
src/main/java/ru/mystamps/web/feature/country/CountryUrl.java-  static final String LIST_COUNTRIES_PAGE     = "/country/list";
--
src/main/java/ru/mystamps/web/feature/series/SeriesUrl.java:    // For backward compatibility
src/main/java/ru/mystamps/web/feature/series/SeriesUrl.java-    static final String ADD_SERIES_WITH_CATEGORY_PAGE = "/series/add/category/{slug}";
@php-coder php-coder added this to the 0.4.2 milestone Sep 9, 2019
@php-coder
Copy link
Owner Author

It seems like this issue obsoletes #518

@php-coder php-coder self-assigned this Oct 13, 2019
@php-coder php-coder mentioned this issue Oct 13, 2019
Closed
4 tasks
php-coder added a commit that referenced this issue Oct 26, 2019
@php-coder
ci: install ansible and ansible-lint in a single command to prevent v…
35d46bb 
…ersions mismatch.

Also install other packages from pip in the same command. This should help us to identify issues
with conflicted dependencies earlier and prevent issues like #1120 and #1148 in future.

Fix #1148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
trivial
Projects
None yet
Milestone
0.4.2
Development

No branches or pull requests
1 participant
@php-coder