Skip to content

Reduce H2 console path hard-coding #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Mar 4, 2020 · 0 comments
Closed

Reduce H2 console path hard-coding #1269

php-coder opened this issue Mar 4, 2020 · 0 comments
Assignees
@mscibilia
Labels
dependency/spring Task is related to Spring Framework refactoring techdebt
Milestone
0.4.4

Comments

@php-coder
Copy link
Owner

Instead of hard-coding /console in SecurityConfig and ContentSecurityPolicyHeaderWriter we can inject H2ConsoleProperties class and obtain a path with H2ConsoleProperties.getPath() method. See example in org.springframework.boot.autoconfigure.security.servlet.PathRequest

Tech debt for #869
@php-coder php-coder added refactoring techdebt dependency/spring Task is related to Spring Framework labels Mar 4, 2020
This was referenced Mar 28, 2020
Closed
Merged
@php-coder php-coder added this to the 0.4.4 milestone Mar 30, 2020
mscibilia added a commit to mscibilia/mystamps that referenced this issue Mar 30, 2020
@mscibilia
refactor: Removed hard-coding of h2 console path and used H2ConsolePr…
35f9f5f 
…operties instead - Fix php-coder#1269
mscibilia added a commit to mscibilia/mystamps that referenced this issue Mar 30, 2020
@mscibilia
refactor: Removed hard-coding of h2 console path and used H2ConsolePr…
4893ef9 
…operties instead

Fix php-coder#1269
mscibilia added a commit to mscibilia/mystamps that referenced this issue Mar 31, 2020
@mscibilia
refactor: Removed hard-coding of h2 console path and used H2ConsolePr…
1038ad4 
…operties instead

Fix php-coder#1269
mscibilia added a commit to mscibilia/mystamps that referenced this issue Mar 31, 2020
@mscibilia
refactor: Removed hard-coding of h2 console path and used H2ConsolePr…
1d813a0 
…operties instead

Fix php-coder#1269
mscibilia added a commit to mscibilia/mystamps that referenced this issue Mar 31, 2020
@mscibilia
refactor: Removed hard-coding of h2 console path and used H2ConsolePr…
13657e0 
…operties instead

Fix php-coder#1269
@php-coder php-coder mentioned this issue Mar 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mscibilia mscibilia

Labels
dependency/spring Task is related to Spring Framework refactoring techdebt
Projects
None yet
Milestone
0.4.4
Development

No branches or pull requests
2 participants
@php-coder @mscibilia