Skip to content

Replace image form: arrange submit buttons in a one line #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0pdd opened this issue Apr 28, 2020 · 1 comment
Open

Replace image form: arrange submit buttons in a one line #1365

0pdd opened this issue Apr 28, 2020 · 1 comment

Comments

@0pdd
Copy link

0pdd commented Apr 28, 2020

The puzzle 1303-25f7ab3b from #1303 has to be resolved:

<!--/* @todo #1303 Replace image form: arrange submit buttons in a one line */-->

The puzzle was created by Slava Semushin on 28-Apr-20.

@php-coder
Copy link
Owner

php-coder commented Apr 28, 2020

I've done that initially but because replace image button was before adding image button, it was activated during a form submission and it broke our tests. I didn't want to change them and use click instead of submit, so I decided to put buttons separately.

This won't be an issue after we migrate this form to React (#1328).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants