Skip to content

React: extend PureComponent instead of Component #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue May 21, 2020 · 0 comments · Fixed by #1403
Closed

React: extend PureComponent instead of Component #1399

php-coder opened this issue May 21, 2020 · 0 comments · Fixed by #1403
Assignees
@bahoss
Labels
area/frontend area/optimization This change could speed up our site estimation/10m Estimated time: 10 minutes trivial
Milestone
0.4.4

Comments

@php-coder
Copy link
Owner

Let's modify all our components to extends PureComponent.

See for details:
@php-coder php-coder added trivial area/optimization This change could speed up our site area/frontend labels May 21, 2020
@php-coder php-coder added this to the 0.4.4 milestone May 21, 2020
@php-coder php-coder added the estimation/10m Estimated time: 10 minutes label May 21, 2020
bahoss added a commit to bahoss/mystamps that referenced this issue May 22, 2020
@bahoss
pref: Extend PureComponent instead of Component Fix php-coder#1399
ec4bd7c
@bahoss bahoss mentioned this issue May 22, 2020
Merged
bahoss added a commit to bahoss/mystamps that referenced this issue May 22, 2020
@bahoss
perf: Extend PureComponent instead of Component
512a25d 
Fix php-coder#1399
php-coder pushed a commit that referenced this issue May 22, 2020
@bahoss @php-coder
perf: Extend PureComponent instead of Component
9bd3102 
Fix #1399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bahoss bahoss

Labels
area/frontend area/optimization This change could speed up our site estimation/10m Estimated time: 10 minutes trivial
Projects
None yet
Milestone
0.4.4
Development

Successfully merging a pull request may close this issue.

perf: Extend PureComponent instead of Component bahoss/mystamps
2 participants
@php-coder @bahoss