Skip to content

Add integration test for validation of unique country's slug #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
php-coder opened this issue Oct 16, 2016 · 0 comments
Closed

Add integration test for validation of unique country's slug #495

php-coder opened this issue Oct 16, 2016 · 0 comments

Comments

@php-coder
Copy link
Owner

Tech debt for: daea019 (#487)

@php-coder php-coder self-assigned this Jan 17, 2017
@php-coder php-coder added this to the 0.4 milestone Jan 17, 2017
@php-coder php-coder changed the title Add integration tests for validation of unique country's slug Add integration test for validation of unique country's slug Jan 25, 2017
Shkarin added a commit to Shkarin/mystamps-1 that referenced this issue Jan 29, 2017
update after remove

Correct update fields update_at/by

remarks correction

update sql query

add fields and sort imports

unit test for collectionDao.markAsModified

fix unit test

correct value for updated_by

remove Date from services

remarks

remarks

ValidationMessages: merge *name-*.invalid messages.

Fix php-coder#279

No functional changes.

ValidationMessages: rename message key.

No functional changes.

WhenAdminAddCategory.categoryNameEnWithAllowedCharactersShouldBeAccepted: port to Robot Framework.

Addressed to php-coder#530

No functional changes.

WhenAdminAddCategory.categoryNameRuWithAllowedCharactersShouldBeAccepted: port to Robot Framework.

Addressed to php-coder#530

No functional changes.

WhenAdminAddCountry.countryNameEnWithAllowedCharactersShouldBeAccepted: port to Robot Framework.

Addressed to php-coder#530

No functional changes.

WhenAdminAddCountry.countryNameRuWithAllowedCharactersShouldBeAccepted: port to Robot Framework.

Addressed to php-coder#530

No functional changes.

Integration tests: remove checkServerResponseCode() check.

I don't want to port it to Robot Framework because
a) it will be hard
b) now I don't think that this check was so useful

WhenAnonymousUserAddCategory: port to Robot Framework.

Addressed to php-coder#530

No functional changes.

category/creation/logic.robot: improve documentation for a keyword.

Should be in 7cfaf2d commit.

No functional changes.

country/creation/logic.robot: improve documentation for a keyword.

Should be in 29c8230 commit.

No functional changes.

WhenAnonymousUserAddCountry: port to Robot Framework.

Addressed to php-coder#530

No functional changes.

WhenAnonymousUserOpenNotExistingCategoryPage: port to Robot Framework.

Addressed to php-coder#530

No functional changes.

WhenAnonymousUserOpenNotExistingCountryPage: port to Robot Framework.

Addressed to php-coder#530

No functional changes.

Add integration tests for checking message about successful operation after adding country/category.

Fix php-coder#208

Add integration test for testing that it's impossible to create category with name that differs only by case.

Fix php-coder#446

Add integration test for testing that it's impossible to create country with name that differs only by case.

Fix php-coder#447

MailServiceImpl.sendMail(): add comment.

No code changes.

MailServiceImpl.sendMail(): add personal to the From header.

No functional changes.

MailServiceImpl.sendMail(): enable e-mail addresses validation.

No functional changes.

Add integration test for validation of unique category slug.

Fix php-coder#494

Add integration test for validation of unique country slug.

Fix php-coder#495

shouldCreateSeriesWithOnlyRequiredFieldsFilled: port to Robot Framework.

Addressed to php-coder#530

No functional changes.

shouldCreateSeriesWithAllFieldsFilled: port to Robot Framework.

Addressed to php-coder#530

No functional changes.

quantityShouldBeANumber: port to Robot Framework.

Addressed to php-coder#530

No functional changes.

quantityShouldBeNotLessThanLimit: port to Robot Framework.

Addressed to php-coder#530

No functional changes.

quantityShouldNotBeGreaterThanLimit: port to Robot Framework.

Addressed to php-coder#530

No functional changes.
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant