Skip to content

Use HTTP protocol properly #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 tasks done
php-coder opened this issue Dec 14, 2016 · 0 comments
Closed
5 tasks done

Use HTTP protocol properly #514

php-coder opened this issue Dec 14, 2016 · 0 comments
Assignees
@php-coder
Labels
refactoring trivial
Milestone
0.4

Comments

@php-coder
Copy link
Owner

php-coder commented Dec 14, 2016 •
edited
Loading

  • We have to change URLs to describe resources, other parameters should go to a query part:
    • /account/activate/key/{key} -> /account/activate?key={key}
    • /series/add/category/{slug} -> /series/add?category={slug}
    • /series/add/country/{slug} -> /series/add?country={slug}
  • "Search by catalog" form should use GET method instead of POST because it doesn't change state
  • We should return 403 error code instead of 401 for unauthenticated requests because 401 must have WWW-Authenticate header

Inspired by article (in Russian): https://habrahabr.ru/company/yandex/blog/265569/
@php-coder php-coder added this to the 0.4 milestone Dec 14, 2016
php-coder added a commit that referenced this issue Dec 27, 2016
@php-coder
Change URL of the activation link to use request parameter insted of …
6351bb8 
…URL variable.

/account/activate/key/{key} -> /account/activate?key={key}

Addressed to #514

No functional changes.
@php-coder php-coder mentioned this issue Dec 27, 2016
Closed
4 tasks
php-coder added a commit that referenced this issue Dec 27, 2016
@php-coder
Change URL of the create series page to use request parameter insted …
e579d53 
…of URL variable.

/series/add/category/{slug} -> /series/add?category={slug}
/series/add/country/{slug} -> /series/add?country={slug}

Now it's also possible to specify both category and country in URL:
/series/add?category={slug}&country={slug}

Addressed to #514

No functional changes.
php-coder added a commit that referenced this issue Dec 27, 2016
@php-coder
Modify search by catalog form to use GET method instead of POST.
c2f0d22 
Addressed to #514

No functional changes.
@php-coder php-coder mentioned this issue Dec 27, 2016
Open
php-coder added a commit that referenced this issue Dec 27, 2016
@php-coder
Return 403 error instead of 401 to anonymous users.
f2d528b 
Because 401 must have WWW-Authenticate header.

Addressed to #514

No functional changes.
@php-coder php-coder self-assigned this Dec 27, 2016
@php-coder php-coder mentioned this issue Dec 28, 2016
Closed
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
@php-coder @bodom91
Change URL of the activation link to use request parameter insted of …
c6abdfd 
…URL variable.

/account/activate/key/{key} -> /account/activate?key={key}

Addressed to php-coder#514

No functional changes.
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
@php-coder @bodom91
Modify search by catalog form to use GET method instead of POST.
0e47826 
Addressed to php-coder#514

No functional changes.
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
@php-coder @bodom91
Return 403 error instead of 401 to anonymous users.
6343bda 
Because 401 must have WWW-Authenticate header.

Addressed to php-coder#514

No functional changes.
@mystamps-bot mystamps-bot mentioned this issue May 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
refactoring trivial
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@php-coder