Skip to content

Change URL from /category/list to /categories (and the same for countries) #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue May 11, 2017 · 2 comments
Closed

Change URL from /category/list to /categories (and the same for countries) #583

php-coder opened this issue May 11, 2017 · 2 comments
Assignees
@php-coder
Labels
kind/improvement trivial
Milestone
0.4

Comments

@php-coder
Copy link
Owner

It turned out that URLs have been chosen wrongly. They don't conform to REST but also create issues like #509 and #510

Let's change them (but keep redirect for backward compatibility).
@php-coder php-coder added this to the next milestone May 11, 2017
@n583wxdh0j n583wxdh0j self-assigned this May 23, 2017
@php-coder
Copy link
Owner Author

You need to modify the following classes:

Here is an example of making permanent redirect.

@php-coder
Copy link
Owner Author

@n583wxdh0j I'm unassigning the issue since there is no activity. Let me know if you're working on it or have a plan to finish it.

@php-coder php-coder modified the milestones: next, 0.4 Dec 18, 2017
@php-coder php-coder self-assigned this Dec 18, 2017
php-coder added a commit that referenced this issue Jan 3, 2018
@php-coder
Deprecate /category/list and add redirect to /categories.
25b2b7c 
Addressed to #583

No functional changes.
php-coder added a commit that referenced this issue Jan 3, 2018
@php-coder
Deprecate /country/list and add redirect to /countries.
bec837e 
Addressed to #583

No functional changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
kind/improvement trivial
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @n583wxdh0j