Skip to content

CategoryServiceImpl.findFirstLevelCategories(): extract representation logic #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue May 18, 2017 · 2 comments
Closed

CategoryServiceImpl.findFirstLevelCategories(): extract representation logic #592

php-coder opened this issue May 18, 2017 · 2 comments
Assignees
@php-coder
Labels
refactoring trivial
Milestone
0.4

Comments

@php-coder
Copy link
Owner

In the commit b7fe1da (#434) I added CategoryServiceImpl.findFirstLevelCategories() that has mix of business and representation logic. We need this conversion only because Thymeleaf lacks ability to do it (details: https://gist.github.com/php-coder/d3020e4d8d00b8c5befe755c46f06f1b).

We should extract the representation logic. This will simplify findFirstLevelCategories() method, makes testing easier and also, when Thymeleaf will support our need or if we'll change the template engine, it will be more straightforward to remove this "hack".

During refactoring we can also move FirstLevelCategoryDto to another package (for example,controller.dto).
@php-coder php-coder added this to the 0.5 milestone May 18, 2017
php-coder added a commit that referenced this issue Nov 30, 2017
@php-coder
GroupByParent.transformParticipants(): extract duplicated code from T…
0644433 
…ransactionParticipantServiceImpl methods.

Also rename original methods.

Addressed to #592

No functional changes.
php-coder added a commit that referenced this issue Nov 30, 2017
@php-coder
GroupByParent.transformCategories(): extract method from CategoryServ…
c88d3b2 
…iceImpl.

Also rename original method.

Addressed to #592

No functional changes.
@php-coder
Copy link
Owner Author

Other related commits that were linked to another issue by mistake: c78b5e5 and 7352780

@php-coder php-coder self-assigned this Dec 3, 2017
@php-coder php-coder modified the milestones: 0.5, 0.4 Dec 3, 2017
php-coder added a commit that referenced this issue Dec 3, 2017
@php-coder
Introduce SelectItem/SelectOption as unified successor of GroupedTran…
a5098d7 
…sactionParticipantDto.

Addressed to #592

No functional changes.
This was referenced Dec 3, 2017
Open
Closed
Closed
Closed
Closed
@php-coder
Copy link
Owner Author

php-coder commented Dec 3, 2017 •
edited
Loading

Extraction were done. Additional refactoring will be performed as part of the subsequent issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
refactoring trivial
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@php-coder