Skip to content

SiteParser: add unit tests #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Nov 7, 2017 · 1 comment
Closed

SiteParser: add unit tests #685

php-coder opened this issue Nov 7, 2017 · 1 comment
Assignees
@php-coder
Labels
area/unit tests techdebt
Milestone
0.4

Comments

@php-coder
Copy link
Owner

Tech debt for 29f6dc9 (#660)
@php-coder php-coder self-assigned this Dec 7, 2017
@php-coder php-coder added this to the 0.4 milestone Dec 7, 2017
php-coder added a commit that referenced this issue Dec 7, 2017
@php-coder
SiteParserTest: add unit tests.
fb63038 
Addressed to #685
This was referenced Dec 7, 2017
Closed
Closed
Closed
php-coder added a commit that referenced this issue Dec 8, 2017
@php-coder
SiteParser.isFullyInitialized(): add unit tests.
96b173b 
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Dec 9, 2017
@php-coder
SiteParserTest.setField(): add unit tests.
81c4b35 
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Dec 9, 2017
@php-coder
SiteParser.extractCategory(): add unit tests.
35cd3ef 
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Dec 9, 2017
@php-coder
SiteParser.extractCountry(): add unit tests.
68ebb9c 
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Dec 9, 2017
@php-coder
SiteParser.extractIssueDate(): add unit tests.
5eb1b71 
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Dec 12, 2017
@php-coder
SiteParser.canParse(): add unit tests.
00fddaf 
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Dec 12, 2017
@php-coder
SiteParser.extractImageUrl(): add unit tests.
1583e82 
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Dec 12, 2017
@php-coder
SiteParser.parse(): add unit tests.
ecfdd3c 
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Jun 14, 2018
@php-coder
JsoupSiteParserTest: fix a sporadic test failure.
adf8b96 
isFullyInitializedWhenAllMandatoryFieldsAreSet test could fail sometimes
with the following error:

  JsoupSiteParserTest.isFullyInitializedWhenAllMandatoryFieldsAreSet:286 JsoupSiteParser[name=wTtSagJviB, matchedUrl=http://example.com/page/H1//h//6z, categoryLocator=null, countryLocator=null, shortDescriptionLocator=null, imageUrlLocator=null, imageUrlAttribute=src, issueDateLocator=null, sellerLocator=null, priceLocator=null, currencyValue=null] expected to be fully initialized
Expected: is <true>
     but: was <false>

Correction for 96b173b commit (#685).
@0pdd
Copy link

0pdd commented Dec 17, 2018

@php-coder all 3 puzzles are solved here: #752, #753, #754.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/unit tests techdebt
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @0pdd