Skip to content

SiteParser: add unit tests #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
php-coder opened this issue Nov 7, 2017 · 1 comment
Closed

SiteParser: add unit tests #685

php-coder opened this issue Nov 7, 2017 · 1 comment
Assignees
Milestone

Comments

@php-coder
Copy link
Owner

Tech debt for 29f6dc9 (#660)

@php-coder php-coder self-assigned this Dec 7, 2017
@php-coder php-coder added this to the 0.4 milestone Dec 7, 2017
php-coder added a commit that referenced this issue Dec 7, 2017
php-coder added a commit that referenced this issue Dec 8, 2017
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Dec 9, 2017
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Dec 9, 2017
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Dec 9, 2017
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Dec 9, 2017
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Dec 12, 2017
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Dec 12, 2017
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Dec 12, 2017
Addressed to #685

No functional changes.
php-coder added a commit that referenced this issue Jun 14, 2018
isFullyInitializedWhenAllMandatoryFieldsAreSet test could fail sometimes
with the following error:

  JsoupSiteParserTest.isFullyInitializedWhenAllMandatoryFieldsAreSet:286 JsoupSiteParser[name=wTtSagJviB, matchedUrl=http://example.com/page/H1//h//6z, categoryLocator=null, countryLocator=null, shortDescriptionLocator=null, imageUrlLocator=null, imageUrlAttribute=src, issueDateLocator=null, sellerLocator=null, priceLocator=null, currencyValue=null] expected to be fully initialized
Expected: is <true>
     but: was <false>

Correction for 96b173b commit (#685).
@0pdd
Copy link

0pdd commented Dec 17, 2018

@php-coder all 3 puzzles are solved here: #752, #753, #754.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants