Skip to content

html5validator flakes with "This document appears to be written in French" #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Dec 29, 2017 · 2 comments
Closed

html5validator flakes with "This document appears to be written in French" #783

php-coder opened this issue Dec 29, 2017 · 2 comments
Assignees
@php-coder
Labels
ADR/needed A decision has been made and it needs to be documented area/integration tests kind/test-flake A test is failing only in some cases
Milestone
0.4

Comments

@php-coder
Copy link
Owner

WARNING:html5validator.validator:"file:/home/travis/build/php-coder/mystamps/src/main/webapp/WEB-INF/views/series/import/list.html":1.16-5.71: info warning: This document appears to be written in French but the "html" start tag has "lang="en"". Consider using "lang="fr"" (or variant) instead.

Seen here: https://travis-ci.org/php-coder/mystamps/jobs/323027743
@php-coder php-coder added area/integration tests kind/test-flake A test is failing only in some cases labels Dec 29, 2017
@php-coder php-coder self-assigned this Dec 29, 2017
@php-coder php-coder added this to the 0.4 milestone Dec 29, 2017
@php-coder
Copy link
Owner Author

The similar failures were workarounded in 0abdb81 and a09a3f5

@php-coder
Copy link
Owner Author

Related upstream issue: svenkreiss/html5validator#32

@php-coder php-coder modified the milestones: 0.4, next Dec 29, 2017
@php-coder php-coder assigned php-coder and unassigned php-coder Dec 29, 2017
@php-coder php-coder modified the milestones: next, 0.4 Dec 29, 2017
php-coder added a commit that referenced this issue Dec 29, 2017
@php-coder
check-build-and-verify.sh: ignore yet another false positive from htm…
27d5637 
…l5validator about document language.

Addressed to #783
@php-coder php-coder added the ADR/needed A decision has been made and it needs to be documented label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
ADR/needed A decision has been made and it needs to be documented area/integration tests kind/test-flake A test is failing only in some cases
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@php-coder