Skip to content

SeriesSalesImportServiceImpl.saveParsedData(): introduce dto without dates #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
0pdd opened this issue Feb 7, 2018 · 1 comment
Open

SeriesSalesImportServiceImpl.saveParsedData(): introduce dto without dates #849

0pdd opened this issue Feb 7, 2018 · 1 comment
Labels
refactoring techdebt

Comments

@0pdd
Copy link

0pdd commented Feb 7, 2018 •
edited by php-coder
Loading

The puzzle 834-3f317328 from #834 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/service/SeriesSalesImportServiceImpl.java

Line 38 in f17ff2b

// @todo #834 SeriesSalesImportServiceImpl.saveParsedData(): introduce dto without dates

The puzzle was created by Slava Semushin on 07-Feb-18.
@0pdd 0pdd added the techdebt label Feb 7, 2018
0pdd referenced this issue Feb 7, 2018
@php-coder
SeriesSalesImportServiceImpl.saveParsedData(): add unit tests.
f17ff2b 
Fix #834
@php-coder
Copy link
Owner

saveParsedData() should have its own dto object that shouldn't have createdAt/updatedAt members. Instead of passing these dates to a method, we should assign them inside of this method.

@0pdd 0pdd mentioned this issue Jul 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring techdebt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@php-coder @0pdd