Skip to content

style: use https where possible #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2020
Merged

Conversation

demianova
Copy link
Contributor

No description provided.

@demianova demianova requested a review from php-coder as a code owner April 23, 2020 22:05
@mystamps-bot
Copy link

mystamps-bot commented Apr 23, 2020

2 Warnings
⚠️ danger check: pull request contains 2 commits while most of the cases it should have only one. If it’s not a special case you should squash the commits into single one.
But be careful because it can destroy all your changes!
⚠️ danger check: looks like you forgot to update ResourceUrl.RESOURCES_VERSION after modifying JS/CSS file(s)

Generated by 🚫 Danger

Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, except a single link.

@php-coder php-coder merged commit 1512041 into php-coder:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants