Do not show null links in buyers/sellers list. #466
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,7 +65,7 @@ | |||
| <insert tableName="transaction_participants"> | |||
| <column name="id" value="3"/> | |||
| <column name="name" value="Duncan MacLeod"/> | |||
| <column name="url" value="http://example.com/duncan-macleod"/> | |||
| <column name="url" value="NULL"/> | |||
There was a problem hiding this comment.
Там поди строчка такая вставится? Если хочешь NULL-то просто ничего не вставляй.
There was a problem hiding this comment.
Я запускал. Все-таки как NULL видит, потому как тег выкусывает.
Могу и убрать, просто хотел подчеркнуть, что именно NULL здесь (чтобы ревьюверу меньше думать пришлось :) ).
There was a problem hiding this comment.
Ревьювер тебя понял. Можешь убирать совсем :)
cssru
force-pushed
the
gh460_hide_null_links
branch
from
a8dafd2 to
af3a252
Compare
|
Merged in 252dc70 commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is