-
-
Notifications
You must be signed in to change notification settings - Fork 315
Closed
Description
In embed/embed/src/Adaptors//File.php the getCode()
method doesn't work properly for remote images.
As far as I can tell, there should be a clause for "imageHTML".
Adding the following clause to getCode()
fixes the problem (Using v3.3.5 with PHP7.1)
case 'imageHtml':
return Utils::imageHtml($this->url,'', $this->imageWidth, $this->imageHeight);
This method's switch
block is also missing a default. It should decide what is a suitable default to pass onto API consmers. Default to a dummy 1px x 1px
image in an <img>
element perhaps? Or throw an exception?
Metadata
Metadata
Assignees
Labels
No labels