Skip to content

Updated include of public suffixes #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Updated include of public suffixes #304

merged 2 commits into from
Feb 19, 2019

Conversation

xyNNN
Copy link
Contributor

@xyNNN xyNNN commented Feb 19, 2019

I've encountered another problem. When you have restricted your include paths via your php.ini your're getting a warning when you using this library. To solve this I've added the @ operator and enforced the return value of this include to be an array.

@oscarotero oscarotero merged commit 96380a2 into php-embed:master Feb 19, 2019
@oscarotero
Copy link
Collaborator

Ok, thanks

@xyNNN
Copy link
Contributor Author

xyNNN commented Feb 20, 2019

Thank you mate, could you create also a patch release so I don't have to require the dev-master? ;) Thanks mate!

@xyNNN
Copy link
Contributor Author

xyNNN commented Feb 25, 2019

Have you some new informations for me? Thanks mate! :) Can I support you in some topic?

oscarotero added a commit that referenced this pull request Feb 25, 2019
@oscarotero
Copy link
Collaborator

Sorry, I missed this. New version released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants