Skip to content

Allow YouTube share url #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 7, 2019
Merged

Allow YouTube share url #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5234fd0
Added test for youtube share url
kmcs Mar 7, 2019
a7de0eb
Allow YouTube share url
kmcs Mar 7, 2019
2206af7
Fixed constant
kmcs Mar 7, 2019
010247b
Remove const
kmcs Mar 7, 2019
caff108
Added missing static modifier
kmcs Mar 7, 2019
f355f09
Fix share url: remove www
kmcs Mar 7, 2019
4ef2c13
Changes as suggested
kmcs Mar 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Providers/OEmbed/Youtube.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@

class Youtube extends EndPoint implements EndPointInterface
{
protected static $pattern = '*youtube.*';
protected static $pattern = ['*youtube.*', '*youtu\.be.*'];
protected static $endPoint = 'http://www.youtube.com/oembed';
}
91 changes: 51 additions & 40 deletions tests/YoutubeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,50 +4,61 @@

class YoutubeTest extends AbstractTestCase
{

static private $expectedVideoInfo = [
'title' => 'Noisy kittens waiting for dinner!',
'imageWidth' => 480,
'imageHeight' => 360,
'type' => 'video',
'authorName' => 'smshdchrb',
'authorUrl' => 'https://www.youtube.com/user/smshdchrb',
'providerName' => 'YouTube',
'providerUrl' => 'https://www.youtube.com/',
'tags' => [
'kittens',
'cats',
'hungry',
'cat',
'baby',
'eight',
'weeks',
'old',
'noisy',
'meow',
'funny',
'kitties',
'feline',
'dinner',
'excited',
'loud',
'cute',
'pet',
'food',
'time',
'felix',
'kitty',
'catz',
'lolcat',
'kitten',
'talking',
'adorable',
'climbing'
],
];

public function testOne()
{
$this->assertEmbed(
'http://www.youtube.com/watch?v=eiHXASgRTcA',
[
'title' => 'Noisy kittens waiting for dinner!',
'imageWidth' => 480,
'imageHeight' => 360,
'type' => 'video',
'authorName' => 'smshdchrb',
'authorUrl' => 'https://www.youtube.com/user/smshdchrb',
'providerName' => 'YouTube',
'providerUrl' => 'https://www.youtube.com/',
'tags' => [
'kittens',
'cats',
'hungry',
'cat',
'baby',
'eight',
'weeks',
'old',
'noisy',
'meow',
'funny',
'kitties',
'feline',
'dinner',
'excited',
'loud',
'cute',
'pet',
'food',
'time',
'felix',
'kitty',
'catz',
'lolcat',
'kitten',
'talking',
'adorable',
'climbing'
],
]
self::$expectedVideoInfo
);
}

public function testShareUrl()
{
$this->assertEmbed(
'http://youtu.be/eiHXASgRTcA',
self::$expectedVideoInfo
);
}

Expand Down