Skip to content

Fixed PHP DOM extension is not specified as requirement. #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

sun
Copy link
Contributor

@sun sun commented Feb 20, 2020

Problem

  • The DOM extension is required, but not specified as required.

Details

  • Some lightweight Linux distributions of PHP do not have all extensions installed by default (e.g. Docker images optimized for speed/size).

@sun
Copy link
Contributor Author

sun commented Feb 20, 2020

The Travis test failures are not related to this PR.

@oscarotero oscarotero merged commit 0f3c985 into php-embed:master Feb 20, 2020
@oscarotero
Copy link
Collaborator

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants