Compatibility issue with Magento

[hugofintecture]

@nicolas-grekas it seems recent changes reintroduced this issue with Magento:

[2023-03-27T14:28:49.214616+00:00] report.DEBUG: The class "Phalcon\HttpMessageRequest" for the generation of "Phalcon\HttpMessageRequestFactory" does not exist. {"exception":"[object] (RuntimeException(code: 0): The class "Phalcon Http Message Request" for the generation of "Phalcon Http Message Request Factory" does not exist. at /app/vendor/magento/framework/Code/Generator.php:223)"} []
[2023-03-27T14:28:49.214928+00:00] report.DEBUG: The "Phalcon\HttpMessage\Stream" class for the generation of "Phalcon\HttpMessage\StreamFactory" does not exist. {"exception":"[object] (RuntimeException(code: 0): The class "Phalcon Http Message" for the generation of "Phalcon Http Message" does not exist. at /app/vendor/magento/framework/Code/Generator.php:223)"} []

Could be related to this path you added?
\Phalcon\Http\Message\RequestFactory::class

Maybe it would be better to use a string there instead of the ::class syntax?

File src/Composer/Plugin.php line 239:

if (class_exists(\Phalcon\Http\Message\RequestFactory::class, false)) {
    $missingRequires[0]['psr/http-factory-implementation'] = [];
    $missingRequires[1]['psr/http-factory-implementation'] = [];
}

Thanks in advance!

[nicolas-grekas]

Would you mind sending a PR after confirming it works for you?

[hugofintecture]

Yes I'll try that :)

[dbu]

ah true, we had to add a hack for magentos classloader:

discovery/src/ClassDiscovery.php

Line 244 in 5cc4283

public static function safeClassExists($class)

[dbu]

should be fixed with https://github.com/php-http/discovery/releases/tag/1.15.3