Skip to content

Fixed typo in method name #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Fixed typo in method name #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be351ee
Fixed typo in method name
GrahamCampbell Jul 10, 2020
d1bc378
Test the replacement method too
GrahamCampbell Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/Psr17FactoryDiscovery.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public static function findUploadedFileFactory()
*
* @throws Exception\NotFoundException
*/
public static function findUrlFactory()
public static function findUriFactory()
{
try {
$messageFactory = static::findOneByType(UriFactoryInterface::class);
Expand All @@ -121,4 +121,16 @@ public static function findUrlFactory()

return static::instantiateClass($messageFactory);
}

/**
* @return UriFactoryInterface
*
* @throws Exception\NotFoundException
*
* @deprecated This will be removed in 2.0. Consider using the findUrlFactory() method.
*/
public static function findUrlFactory()
{
return static::findUriFactory();
}
}
1 change: 1 addition & 0 deletions tests/Psr17FactoryDiscoveryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ public function getFactories()
yield ['findServerRequestFactory', ServerRequestFactoryInterface::class];
yield ['findStreamFactory', StreamFactoryInterface::class];
yield ['findUploadedFileFactory', UploadedFileFactoryInterface::class];
yield ['findUriFactory', UriFactoryInterface::class];
yield ['findUrlFactory', UriFactoryInterface::class];
}
}