Skip to content

Allow installing on PHP 8. #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2020
Merged

Allow installing on PHP 8. #45

merged 2 commits into from
Oct 17, 2020

Conversation

ADmad
Copy link
Contributor

@ADmad ADmad commented Aug 14, 2020

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets N/A
Documentation N/A
License MIT

What's in this PR?

Allow installing on PHP 8.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

To Do

  • If the PR is not complete but you want to discuss the approach, list what remains to be done here

@ADmad ADmad marked this pull request as ready for review August 14, 2020 19:38
@ADmad
Copy link
Contributor Author

ADmad commented Aug 18, 2020

Ping

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the MR. PHP 8 is not yet released, i am not sure we should merge this before it is. then again its a testing library, so it would not be that much of a problem if there are any last-minute changes in php 8.

i fixed the styleci configuration error in master. your changes don't touch any php files, so it is not necessary to rebase.

@Nyholm do you agree we merge this?

@ADmad
Copy link
Contributor Author

ADmad commented Aug 19, 2020

thanks for the MR. PHP 8 is not yet released, i am not sure we should merge this before it is. then again its a testing library, so it would not be that much of a problem if there are any last-minute changes in php 8.

People won't be able to try out the PHP 8 beta/RC releases and provide feedback/bug reports if they are not able to test their code with it 🙂. Testing libs like this should absolutely be updated now so as to not block the upgrading/testing of the whole ecosystem which depend on it.

@ADmad
Copy link
Contributor Author

ADmad commented Aug 31, 2020

Is there anything more I need to do here?

@mnapoli
Copy link

mnapoli commented Oct 5, 2020

🙏 please :)

Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edudobay edudobay mentioned this pull request Oct 10, 2020
1 task
@weierophinney
Copy link
Contributor

bump

RC2 just dropped, so PHP 8 is reaching relative stability. A number of PSR-7 providers are trying to ensure they are ready (e.g., Diactoros, Slim), but we are all currently blocked until this is merged.

@Nyholm
Copy link
Member

Nyholm commented Oct 16, 2020

I’ll review and make sure this is merged tonight or tomorrow.

Thank you for the ping

@Nyholm
Copy link
Member

Nyholm commented Oct 17, 2020

Im fine this. Thank you

@Nyholm Nyholm merged commit b63c2f5 into php-http:master Oct 17, 2020
@Nyholm
Copy link
Member

Nyholm commented Oct 17, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants