-
Notifications
You must be signed in to change notification settings - Fork 21
Allow installing on PHP 8. #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the MR. PHP 8 is not yet released, i am not sure we should merge this before it is. then again its a testing library, so it would not be that much of a problem if there are any last-minute changes in php 8.
i fixed the styleci configuration error in master. your changes don't touch any php files, so it is not necessary to rebase.
@Nyholm do you agree we merge this?
People won't be able to try out the PHP 8 beta/RC releases and provide feedback/bug reports if they are not able to test their code with it 🙂. Testing libs like this should absolutely be updated now so as to not block the upgrading/testing of the whole ecosystem which depend on it. |
Is there anything more I need to do here? |
🙏 please :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bump RC2 just dropped, so PHP 8 is reaching relative stability. A number of PSR-7 providers are trying to ensure they are ready (e.g., Diactoros, Slim), but we are all currently blocked until this is merged. |
I’ll review and make sure this is merged tonight or tomorrow. Thank you for the ping |
Im fine this. Thank you |
What's in this PR?
Allow installing on PHP 8.
Checklist
To Do