Skip to content
This repository was archived by the owner on Jul 16, 2025. It is now read-only.

Conversation

valtzu
Copy link
Contributor

@valtzu valtzu commented Jul 7, 2025

Recently added Gemini server_tools are not configurable via bundle config because options only allows scalars – same thing for any nested config (like thinkingConfig: { thinkingBudget: 0 }).

@valtzu valtzu changed the title Allow array arguments in model.options fix: Allow array arguments in model.options Jul 7, 2025
@OskarStark
Copy link
Contributor

Would love to have a testcase 🙌

@valtzu valtzu force-pushed the allow-array-options branch from 27fde91 to fff543b Compare July 7, 2025 18:55
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @valtzu!

@chr-hertel chr-hertel merged commit 072fa56 into php-llm:main Jul 8, 2025
7 checks passed
chr-hertel added a commit to symfony/ai that referenced this pull request Jul 13, 2025
This PR was merged into the main branch.

Discussion
----------

fix: Allow array arguments in `model.options`

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Docs?         |
| Issues        |
| License       | MIT

Cherry picking php-llm/llm-chain-bundle#103

Commits
-------

0082388 fix: Allow array arguments in `model.options` (#103)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants