This repository was archived by the owner on Jul 16, 2025. It is now read-only.
refactor!: improve types in platform api #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smnandre
reviewed
Jul 5, 2025
smnandre
reviewed
Jul 5, 2025
|
This looks pretty cool! Thanks @chr-hertel - those assertions you mentioned are all over the place and this looks like a cool solution. Mostly one knows what kind of request was sent and what should be the response but for type safety checks where required. Wrapping those checks to the library with the |
chr-hertel
force-pushed
the
refactor-platform-types
branch
from
77d71aa to
5471c77
Compare
chr-hertel
force-pushed
the
refactor-platform-types
branch
from
5471c77 to
b2e94eb
Compare
chr-hertel
force-pushed
the
refactor-platform-types
branch
from
b2e94eb to
26e6ced
Compare
chr-hertel
requested review from
smnandre and
OskarStark
and removed request for
smnandre
This was referenced Jul 6, 2025
|
This PR demonstrates the benefits for lib users quite well I guess: |
chr-hertel
added a commit
to symfony/ai
that referenced
this pull request
Jul 7, 2025
This PR was merged into the main branch. Discussion ---------- refactor!: improve types in platform api | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | | License | MIT Cherry picking php-llm/llm-chain#376 Commits ------- bfa7cd4 refactor!: improve types in platform api (#376)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was just tired of doing those
assert($response instanceof ...);statementsalso resolves the special status of
AsyncResponseby decoupling it from theResponseInterfaceWDYT?