Skip to content

feat(symfony): add bridge for Symfony #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mremi
Copy link

@mremi mremi commented Jul 1, 2025

No description provided.

@mremi
Copy link
Author

mremi commented Jul 2, 2025

Hi @CodeWithKyrian could you please have a look?

@CodeWithKyrian
Copy link
Contributor

Hey man! Thanks so much for putting this together. You really put a lot of effort into this,and it looks solid from what I can tell (I'm not really a symfony person tbh). Really appreciate you taking the time to contribute!

However, I'm going to have to pass on merging this into the main server package. The core philosophy I'm trying to maintain here is keeping the base server package completely framework-agnostic. I want it to stay as a lean, pluggable foundation that anyone can build on top of without pulling in dependencies they don't need.

This is exactly why I created the Laravel integration as a separate php-mcp/laravel package rather than bundling it into the server. That package gets to fully embrace Laravel's ecosystem - it uses the HTTP kernel, integrates with routing, leverages service providers, etc. It's a much richer integration because it doesn't have to compromise.

I'd suggest you take the same approach with Symfony. You could create your own symfony-mcp or similar package that extends this package, and really leans into Symfony's strengths. Feel free to study how the Laravel package works - it might give you some ideas for deeper integrations.

If you find that the server package is missing integration points that would make your Symfony package easier to build, definitely let me know. I'm always open to adding hooks or interfaces that make framework integrations smoother without tying the core to any specific framework.

What do you think about taking that route instead? And hey, if it turns out well, we could even consider adopting it into the php-mcp organization in the future 🤷🏽‍♂️

@mremi
Copy link
Author

mremi commented Jul 2, 2025

Thanks for your feedback, I do understand what you mean, that's why no Symfony dependencies are required here, but only suggested (and in require-dev for testing purpose), no overhead. So we could imagine the same integration for other frameworks, like Laravel.

Let me know, I'll close it if you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants