Refactor MQTT client loop implementation to allow easier integration with third party event loops #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactoring add a loopOnce method to MqttClient class. This method allows the MQTT client implementation to be integrated to an event loop (like ReactPHP - Ratchet).
|
Thank you for the contribution, I like the idea! To better align the code with the remaining code, I've added the method to the interface and changed a few minor things. As soon as I've found out what is wrong with the build, I'll merge and release the change. Looks like a TLS issue, probably support for some old TLS version was dropped... |
Closed
|
No idea what's wrong with the build. Running it in #117 from a branch in this repository did work and even fix the result in this PR. Strange. |
Namoshek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring add a loopOnce method to MqttClient class.
This method allows the MQTT client implementation to be integrated to an event loop (like ReactPHP - Ratchet).