Skip to content

Implement delivery of retain flag #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2023
Merged

Implement delivery of retain flag #169

merged 3 commits into from
Nov 25, 2023

Conversation

Namoshek
Copy link
Collaborator

@Namoshek Namoshek commented Nov 24, 2023 •
edited
Loading

This PR adds the retain flag provided by MQTT brokers to delivered messages. For some reason, this was never implemented.

Details:

  • The addition requires breaking a few of the internal APIs, hence this PR forces a major version bump at release.
  • Because the tests for the retained flag will leak the published messages to other tests, some randomization was added for the topics used by these test cases.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2023 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

.github/workflows/tests.yml

@Namoshek Namoshek mentioned this pull request Nov 24, 2023
Closed
@Namoshek Namoshek merged commit 532339e into master Nov 25, 2023
@Namoshek Namoshek deleted the feature/retain-flag-on-published-messages branch November 25, 2023 19:07
@Namoshek Namoshek added the enhancement New feature or request label Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Namoshek