More tests for padding #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
============================================
+ Coverage 96.95% 97.04% +0.08%
Complexity 356 356
============================================
Files 23 23
Lines 1117 1117
============================================
+ Hits 1083 1084 +1
+ Misses 34 33 -1
Continue to review full report at Codecov.
|
Lynesth
reviewed
May 11, 2018
| @@ -404,7 +404,7 @@ private function generatePaddingTopBottomRows() : void | |||
| "%s%s%s%s%s%s%s%s%s%s\n", | |||
| str_repeat(' ', $this->margin), | |||
| $borderColour, | |||
| str_repeat(' ', $this->borderRightWidth), | |||
| str_repeat(' ', $this->borderLeftWidth), | |||
|
All good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a bunch of tests for padding, also uncovered a bug where the right border width was used instead of left border width!
Could you take a look please @Lynesth :)