Split item menu tests #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## split-item-builder #132 +/- ##
=======================================================
+ Coverage 87.18% 94.4% +7.21%
+ Complexity 418 417 -1
=======================================================
Files 26 26
Lines 1280 1287 +7
=======================================================
+ Hits 1116 1215 +99
+ Misses 164 72 -92
Continue to review full report at Codecov.
|
Lynesth
reviewed
May 13, 2018
|
|
||
| $length -= $this->margin; | ||
|
|
||
| $length = floor($style->getContentWidth() / $numberOfItems) - $this->margin; |
There was a problem hiding this comment.
$length = $style->getDisplaysExtra()
? floor($style->getContentWidth() / $numberOfItems) - $this->margin - (mb_strlen($style->getItemExtra()) + 2)
: floor($style->getContentWidth() / $numberOfItems) - $this->margin;| array_map(function ($index, $item) use ($selected, $length, $style) { | ||
| $isSelected = $selected && $index === $this->selectedItemIndex; | ||
| $marker = $item->canSelect() | ||
| ? sprintf('%s ', $style->getMarker($isSelected)) | ||
| : ''; |
There was a problem hiding this comment.
$itemExtra = $style->getDisplaysExtra() && $item->showsItemExtra()
? sprintf(' %s', $style->getItemExtra())
: '';| explode("\n", StringUtil::wordwrap(sprintf('%s%s', $marker, $item->getText()), $length)), | ||
| $length, | ||
| $style, | ||
| $isSelected |
There was a problem hiding this comment.
add the $itemExtra variable too
| ); | ||
| } | ||
|
|
||
| private function buildCell(array $content, int $length, MenuStyle $style, bool $isSelected) : array |
There was a problem hiding this comment.
add the string $itemExtra argument
src/MenuItem/SplitItem.php
Outdated
|
|
||
| return $rows; | ||
| return sprintf( | ||
| '%s%s%s%s%s', |
| '%s%s%s%s%s', | ||
| $invertedColoursSetCode, | ||
| $row, | ||
| str_repeat(' ', $length - mb_strlen($row)), |
There was a problem hiding this comment.
and insert this just after that line:
$itemExtra,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.