Skip to content

Remove backports, alert for insensitive file systems, and bundled file entity for directories #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

alfsb
Copy link
Member

@alfsb alfsb commented Jan 20, 2025

This PR:

  • Remove old code (backports) from file-entities.php;
  • Generate a error for filenames that bricks manual build on insensitive file systems (Windows);
  • Generate file entities for directories as normal entries on file-entities.ent, instead of individual file names.

The last one avoids generating and loading about a thousand temporary files, per configure.php.

Tested on all languages. Need tests on Windows boxes, to see if LIBXML_PARSEHUGE behave the same as on Linux machines.

@alfsb alfsb mentioned this pull request Jan 20, 2025
29 tasks
@alfsb
Copy link
Member Author

alfsb commented Jan 22, 2025

Tested on Win10, depends on #214 . So I would first merge that, wait, and then merge this.

@alfsb
Copy link
Member Author

alfsb commented Jan 27, 2025

Thanks for the approval. I plan to merge this next week, and in the meantime to work into making XML sync tests more usable in more languages.

@alfsb alfsb merged commit a4884fb into php:master Feb 3, 2025
8 of 12 checks passed
@alfsb
Copy link
Member Author

alfsb commented Feb 3, 2025

Merged. Let me know if are side effects. Windows testing would be very welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants