DateTimeZone::listIdentifiers improvements #4882
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AllenJB
commented
Sep 24, 2025
AllenJB
commented
- Added a method description, with link to help developers understand where these identifiers come from
- Added note about detecting browser timezone with JS with links to MDN, since this is a common use of this function
- Improved the first example with location comments to help users select their timezone (thanks to @derickr https://derickrethans.nl/selecting-time-zones.html )
- Checked and added interactive annotations
Crell
reviewed
Sep 24, 2025
derickr
reviewed
Sep 25, 2025
AllenJB
added a commit
to AllenJB/doc-base
that referenced
this pull request
Sep 27, 2025
|
CI failure appears to be due to link entities - see linked PR |
Crell
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.