Retain original $host parameter name of ldap_connect()

[kocsismate]

No description provided.

[kamil-tekiela]

I'm not convinced by this. The parameter name is still $uri, but for backwards compatibility, you can provide only the hostname as a value. This should be documented differently. The signature doesn't change. In fact, it looks like there are 2 signatures, but there is no signature that accepts just one parameter.

I am not very familiar with LDAP, but it seems to me like we would want to document the actual signature and then explain the weird behaviour with passing the hostname as the $uri parameter. Specifying pseudo-parameters in the manual to explain strange behaviour doesn't sit well with me.

[cmb69]

This PR looks good to me. This function is basically overloaded: either pass the URI, or pass hostname and port. The latter won't work with named arguments, but is soft deprecated anyway. And as it is now, we have two descriptions of the $uri parameter.

[kocsismate]

Yeah, I agree with Christoph: while I admit that this PR is very far from perfect, but at least it retains the previous state of the page by fixing an issue with the duplicated param name. As I have no intention for further improving the documentation of ldap_connect, I think it's a sensible hotfix for now. Hopefully someone in the future will feel the urge to review the content of this page, and will the document all the missing parameters.

[cmb69]

plus actually deprecate the old signature...

[kocsismate]

plus actually deprecate the old signature...

At some point of the development cycle of PHP 8.2, I plan to start an RFC which would globally tackle all overloaded signatures, where possible (first example: php/php-src#6754).

[afilina]

Pinging reviewer @cmb69: it seems like you gave an informal approval in the comments. Can we formalize the approval or merge?

[cmb69]

Oh, indeed, this could be merged. Thank you!