number_format shouldn't round

[simplysara]

Description

From manual page: https://php.net/function.number-format

Why is this method rounding. It should simply format the number. If I wanted to round I would use round().

php-src/ext/standard/math.c

Line 1256 in 94d0b41

// rounding the number

Documentation in lib file mentions nothing about rounding.
`/**

• Format a number with grouped thousands
• @link https://php.net/manual/en/function.number-format.php
• @param float $num

• The number being formatted.
• @param int $decimals [optional]

• Sets the number of decimal points.
• @param string|null $decimal_separator [optional]
• @param string|null $thousands_separator [optional]
• @return string A formatted version of number.
  */
  #[Pure]
  function number_format(float $num, int $decimals = 0, ?string $decimal_separator = '.', ?string $thousands_separator = ','): string {}
  `

[iluuu1994]

Hi @simplysara. Floats are not infinitely precise numbers. Sometimes, you can get seemingly strange numbers as a result of arithmetic operations. https://3v4l.org/gp15D That's why number_format() makes you pass the $decimals argument to specify how many digits after the decimal point are relevant to your case.