mb_detect_encoding is more accurate on strings with UTF-8/16 BOM #10373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to the GitHub user 'titanz35' for pointing out that the new implementation of mb_detect_encoding had poor detection accuracy on UTF-8 and UTF-16 strings with a byte-order mark.
Girgias
reviewed
Jan 18, 2023
That's a good idea. |
|
Looks good to me. |
|
Hmm, the patch doesn't apply on PHP-8.1 because the code has been refactored on PHP-8.2... |
|
Hmm, it doesn't even apply on PHP-8.2. |
|
Merging into PHP 8.3 for now. Applying the same fix to 8.1 and 8.2 might be done later (though it's more difficult to do this with the legacy code). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the GitHub user 'titanz35' for pointing out that the new implementation of mb_detect_encoding had poor detection accuracy on UTF-8 and UTF-16 strings with a byte-order mark.
This relates to #7871. That issue is primarily about the detection accuracy of
mb_detect_encodingon strings which contain emoji, but one commenter also pointed out a problem with strings that start with a byte-order mark. Once the emoji issue is also worked out, then #7871 can be closed.@cmb69 @Girgias @nikic @kamil-tekiela @youkidearitai