Skip to content

Fix GH-10651: mbfl_filt_conv_jis_wchar() state transition to JIS X 0201 when 0x0f is passed #10652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pakutoma
Copy link
Contributor

I am new to PHP contributions, so please let me know if I am doing something wrong.

@nielsdos
Copy link
Member

Thank you for your contribution!
Since this is a bugfix, and you said in your issue that it reproduces on 8.1, this needs to target branch PHP-8.1 instead of master.
Could you also please write a test case for this issue? (https://qa.php.net/write-test.php)

@alexdowad
Copy link
Contributor

@nielsdos is very right that this should target PHP 8.1, and that there should be tests. But an even bigger issue is whether we want to make this change or not. It would be a BC break.

As with all other issues, I am open to either conclusion. But let's discuss it thoroughly before jumping to a PR.

@pakutoma
Copy link
Contributor Author

The issue concluded that no modification is necessary, so I will close it.

@pakutoma pakutoma closed this Feb 21, 2023
@alexdowad
Copy link
Contributor

The issue concluded that no modification is necessary, so I will close it.

@pakutoma If that is your conclusion, I accept it. But please don't think that because I raised a concern, it means your changes are not wanted.

We are always interested in hearing your views and those of other PHP users, and are open to (possibly) making changes when there are logical reasons to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants