Skip to content

Silence compiler warnings in ext/sockets/conversions.c #10974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2023
Merged

Silence compiler warnings in ext/sockets/conversions.c #10974

merged 1 commit into from
Mar 29, 2023

Conversation

nielsdos
Copy link
Member

These values will be initialised, but the compiler can't see it. Write a dummy value to silence this.

Closes GH-10959.

@nielsdos
Silence compiler warnings in ext/sockets/conversions.c
a668920 
These values will be initialised, but the compiler can't see it.
Write a dummy value to silence this.

Closes phpGH-10959.
@nielsdos nielsdos requested a review from devnexen as a code owner March 29, 2023 18:05
@nielsdos nielsdos requested review from Girgias and removed request for devnexen March 29, 2023 18:05
@nielsdos
Copy link
Member Author

Hmmm Upon adding @Girgias as reviewer GitHub auto-removed @devnexen (code-owner) review request, and now I can't add him anymore for some reason... Strange.

@Girgias Girgias requested a review from devnexen March 29, 2023 18:14
@nielsdos nielsdos merged commit b606e44 into php:master Mar 29, 2023
@nielsdos
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@Girgias Girgias Awaiting requested review from Girgias

Assignees
No one assigned
Labels
Extension: sockets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completely unnecessary compiler warnings in function ‘from_zval_write_sockaddr_aux’
2 participants
@nielsdos @devnexen