Skip to content

ext/openssl: Prevent exposed error when using a PEM public key #11055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

ext/openssl: Prevent exposed error when using a PEM public key #11055

wants to merge 6 commits into from

Conversation

famoser
Copy link
Contributor

@famoser famoser commented Apr 10, 2023 •
edited
Loading

Issue: #11054

Note that:

  • I had to adapt existing tests.
  • There is one test failing on windows (FAIL openssl_pkey_derive() ECDH [D:\a\php-src\php-src\ext\openssl\tests\openssl_pkey_derive-ecdh.phpt]); I do not see how this change had an impact there.

@famoser famoser requested a review from bukka as a code owner April 10, 2023 18:13
bukka
bukka requested changes Apr 17, 2023
View reviewed changes
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks reasonable. Just few changes needed.

@famoser
Copy link
Contributor Author

famoser commented Apr 17, 2023

Thank you for the review, much appreciated. I applied the requested changes.

@famoser famoser requested a review from bukka April 17, 2023 15:57
bukka
bukka approved these changes May 6, 2023
View reviewed changes
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now. Just approved pipeline so if it passes, then it should be all good. It is actually technically an ABI break so I cannot merge it to anything else than master.

@bukka bukka closed this in 4d4b960 May 6, 2023
@pronskiy pronskiy mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bukka bukka bukka approved these changes

Assignees
No one assigned
Labels
Extension: openssl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@famoser @bukka