Skip to content

Store the original path used to open xport stream #11113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Apr 21, 2023

Currently, with a code like $stream = stream_socket_client("ssl://www.example.com:443"), the original path used to open the stream is not stored.

This PR proposes to store it so it can be retrieved later.

@iamluc iamluc requested a review from bukka as a code owner April 21, 2023 15:00
@iamluc iamluc changed the title Store the orig_path for xport stream Store the original path used to open xport stream Apr 21, 2023
@iamluc iamluc force-pushed the xport-stream-orig_path branch from 13fbc40 to 590c00b Compare April 21, 2023 15:32
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense.

@ondrejmirtes
Copy link
Contributor

Hi, can you please verify this change makes uri offset to always be present in stream_get_meta_data calls? Thanks.

@iamluc iamluc deleted the xport-stream-orig_path branch September 17, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants