Add configuration opcache.jit_max_trace_length #11173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxue1
force-pushed
the
jit_max_trace_length
branch
from
6108282 to
3a3ee01
Compare
dstogov
requested changes
May 2, 2023
| @@ -336,6 +349,7 @@ ZEND_INI_BEGIN() | |||
| STD_PHP_INI_ENTRY("opcache.jit_max_recursive_calls" , "2", PHP_INI_ALL, OnUpdateUnrollC, max_recursive_calls, zend_jit_globals, jit_globals) | |||
| STD_PHP_INI_ENTRY("opcache.jit_max_recursive_returns" , "2", PHP_INI_ALL, OnUpdateUnrollR, max_recursive_returns, zend_jit_globals, jit_globals) | |||
| STD_PHP_INI_ENTRY("opcache.jit_max_polymorphic_calls" , "2", PHP_INI_ALL, OnUpdateLong, max_polymorphic_calls, zend_jit_globals, jit_globals) | |||
| STD_PHP_INI_ENTRY("opcache.jit_max_trace_length" , "512", PHP_INI_ALL, OnUpdateUnrollT, max_trace_length, zend_jit_globals, jit_globals) | |||
There was a problem hiding this comment.
Please keep the old default value "1024" to keep the original behaviuor.
| @@ -258,6 +258,19 @@ static ZEND_INI_MH(OnUpdateUnrollL) | |||
| ZEND_JIT_TRACE_MAX_LOOPS_UNROLL); | |||
| return FAILURE; | |||
| } | |||
|
|
|||
| static ZEND_INI_MH(OnUpdateUnrollT) | |||
There was a problem hiding this comment.
Please, use a better name - OnUpdateMaxTraceLength
ext/opcache/jit/zend_jit_trace.c
Outdated
| @@ -7591,7 +7591,7 @@ int ZEND_FASTCALL zend_jit_trace_hot_root(zend_execute_data *execute_data, const | |||
| zend_jit_op_array_trace_extension *jit_extension; | |||
| size_t offset; | |||
| uint32_t trace_num; | |||
| zend_jit_trace_rec trace_buffer[ZEND_JIT_TRACE_MAX_LENGTH]; | |||
| zend_jit_trace_rec *trace_buffer = (zend_jit_trace_rec *)malloc(JIT_G(max_trace_length) * sizeof(zend_jit_trace_rec)); | |||
There was a problem hiding this comment.
Keep the preallocated trace_buffer. Your patch limits the upper bound anyway.
Note: In case you swittch to malloc() you need to free() the buffer later.
Anyway, it's easier and more efficient to keep the preallocated buffer.
ext/opcache/jit/zend_jit_trace.c
Outdated
| zend_jit_trace_rec trace_buffer[ZEND_JIT_TRACE_MAX_LENGTH]; | ||
| zend_jit_trace_rec *trace_buffer = (zend_jit_trace_rec *)malloc(JIT_G(max_trace_length) * sizeof(zend_jit_trace_rec)); |
There was a problem hiding this comment.
The same.
Thanks, all are done
wxue1
force-pushed
the
jit_max_trace_length
branch
from
3a3ee01 to
86788cb
Compare
Max length of a single trace. A long trace generates long JITTed code, which influences the performance slightly. opcache.jit_max_trace_length range is [4,1024], the default value is 1024. Signed-off-by: Wang, Xue <[email protected]> Reviewed-by: Su, Tao <[email protected]>
wxue1
force-pushed
the
jit_max_trace_length
branch
from
86788cb to
1d66114
Compare
dstogov
approved these changes
May 2, 2023
llaville
added a commit
to llaville/php-compatinfo-db
that referenced
this pull request
Oct 10, 2023
llaville
added a commit
to llaville/php-compatinfo-db
that referenced
this pull request
Nov 18, 2023
llaville
added a commit
to llaville/php-compatinfo-db
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Max length of a single trace. A long trace generates long JITTed code, which influences the performance slightly.
opcache.jit_max_trace_length range is [4,1024], the default value is 1024 now.
Signed-off-by: Wang, Xue [email protected]
Reviewed-by: Su, Tao [email protected]