-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix #9483: Fix autoconf warnings due to old libtool #11207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have limited libtool knowledge, but I think the changes are correct. I also tested them and it seems to work fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. ah autoconf :-) will we migrate to cmake ? joke
Is there a way to backport it to 8.2? |
We can, but we should then backport add also some others: #10383. |
There's only 2? |
Filed #11279 |
For PHP 8.1 I also using c68591f as patch |
Yes, I think these two are the only ones needed to remove the autoconf warnings. 👍 |
No description provided.