Skip to content

Fix #9483: Fix autoconf warnings due to old libtool #11207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2023

Conversation

petk
Copy link
Member

@petk petk commented May 8, 2023

No description provided.

@petk petk mentioned this pull request May 8, 2023
@petk petk marked this pull request as ready for review May 8, 2023 15:39
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have limited libtool knowledge, but I think the changes are correct. I also tested them and it seems to work fine.

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. ah autoconf :-) will we migrate to cmake ? joke

devnexen

This comment was marked as spam.

@Girgias Girgias merged commit aae39fe into php:master May 15, 2023
@andypost
Copy link
Contributor

Is there a way to backport it to 8.2?

@petk
Copy link
Member Author

petk commented May 19, 2023

Is there a way to backport it to 8.2?

We can, but we should then backport add also some others: #10383.

@andypost
Copy link
Contributor

There's only 2?

andypost pushed a commit to skilld-labs/php-src that referenced this pull request May 19, 2023
@andypost
Copy link
Contributor

Filed #11279

@andypost
Copy link
Contributor

For PHP 8.1 I also using c68591f as patch

@petk
Copy link
Member Author

petk commented May 20, 2023

Yes, I think these two are the only ones needed to remove the autoconf warnings. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants