Quick fix for resolving issue #11099

[peter279k]

Changed log

• It's the quick fix for resolving the issue Generating phar.php during cross-compile can't be done #11099. It can ignore error about generating phar steps when running the cross compiling.

[nielsdos]

I think ideally we would still catch errors during generation, for example if a bug in the generation process is introduced or due to other errors. I think it would be possible to detect only ENOEXEC errors.

[peter279k]

@nielsdos, thanks for your suggestion.

I define the TEST_PHP_EXECUTABLE and TEST_PHP_EXECUTABLE_RES variables to check whether the executable PHP binary is the correct format.

If presenting the Exec format error message, it will skip phar.php, phar.phar and install-pharcmd steps.

I think it can achieve the recommendation you suggest :).

[nielsdos]

Thanks this looks better already. I wonder whether it is possible to store a 1 or 0 into the res variable to clean up the checks. I also think it would be great if a short warning message gets printed when the phar file cannot be generated because of a cross compile, so people will not be surprised it isn't generated.
Finally, I'm not the build system expert here, so maybe @petk has some suggestions as well?

[peter279k]

@nielsdos, thanks for your advanced recommendations.

I use the 0 or 1 to cleanup checks and presenting the warning message when skipping these steps.

[nielsdos]

Thanks for your work! It looks almost good. Just two small mistakes slipped in while you changed the commands: two times you put two commands on the same line instead of keeping them separate.

[nielsdos]

You put two separate lines into one line. This used to be two lines:

@$(mkinstalldirs) $(INSTALL_ROOT)$(bindir)
$(INSTALL) $(builddir)/phar.phar $(INSTALL_ROOT)$(bindir)/$(program_prefix)phar$(program_suffix).phar

But now you put them on one line, which means the command won't work properly.

[nielsdos]

Same problem here:

rm -f $(INSTALL_ROOT)$(bindir)/$(program_prefix)phar$(program_suffix)
$(LN_S) -f $(program_prefix)phar$(program_suffix).phar $(INSTALL_ROOT)$(bindir)/$(program_prefix)phar$(program_suffix)

should be on two separate lines (with ; \ like you did for the other lines of course). But you put them on the same line, which makes the command not work properly.

[nielsdos]

Thank you for your contribution! This looks good to me and works in my tests. As usual, I'll wait a few days for more feedback. If no more feedback comes in I'll merge it.