Skip to content

Avoid allocating temporaries on the call frame for property hook trampolines #16287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

Avoid allocating temporaries on the call frame for property hook trampolines #16287

merged 1 commit into from
Mar 25, 2025

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Oct 7, 2024

As pointed out in #16252 (comment)

@nielsdos nielsdos marked this pull request as ready for review October 7, 2024 19:43
@nielsdos nielsdos requested a review from dstogov as a code owner October 7, 2024 19:43
@nielsdos nielsdos requested a review from iluuu1994 October 7, 2024 19:43
iluuu1994
iluuu1994 reviewed Oct 7, 2024
View reviewed changes
iluuu1994
iluuu1994 approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better late than never 😋 Took me a second to understand, but this LGTM.

@nielsdos nielsdos merged commit 7acce8a into php:master Mar 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @iluuu1994