Fix GH-16290: session cookie_lifetime ini value overflow. #16295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Girgias what do you think should be a reasonable max value for cookie_lifetime ? |
|
I think that boundary is sensible. Having cookies set for over a year seems bad practice anyway. |
devnexen
force-pushed
the
gh16290
branch
2 times, most recently
from
13104f1 to
0a0e489
Compare
|
While it may be bad practice, making them fail to set the lifetime is a BC break, as setting it to e.g. 1Y+1D would break real code now. I think we should just prevent the overflow and be done with it. |
Yes I was not saying that we should make it fail, just pointing out that it seems unlikely to cause any issues as I wouldn't expect a timeout to be set that high. |
devnexen
force-pushed
the
gh16290
branch
4 times, most recently
from
0b76b81 to
6699ede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.