fileinfo: Deprecate finfo_close()
#18396
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added this to https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_finfo_close already |
|
Thanks, I've linked this PR in the RFC as the implementation. |
|
I think merging the test changes already is fine. But having it in the bulk RFC is probably the "proper" way to do it, even if I would agree just deprecating it should be fine. |
|
This is for consistency with other `*_close()` functions that have become obsolete when migrating from resources to objects.
TimWolla
force-pushed
the
finfo-close-deprecate
branch
from
3ebec92 to
bad3cef
Compare
jorgsowa
reviewed
Apr 23, 2025
| @@ -92,6 +92,7 @@ public function set_flags(int $flags): true {} | |||
| /** @refcount 1 */ | |||
| function finfo_open(int $flags = FILEINFO_NONE, ?string $magic_database = null): finfo|false {} | |||
|
|
|||
| #[\Deprecated(since: '8.5', message: 'as finfo objects are freed automatically')] | |||
There was a problem hiding this comment.
Suggested change
| #[\Deprecated(since: '8.5', message: 'as finfo objects are freed automatically')] | |
| #[\Deprecated(since: 'PHP 8.5', message: 'as finfo objects are freed automatically')] |
Isn't it better to be explicit about the version? There may be case that the plain version number may be confused with other software, i.e. MySQL has close version number.
There was a problem hiding this comment.
This is a discussion for another place. The “bare version” format is what is currently used by PHP core. See: 29f98e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this need an RFC or can we do this by simple agreement? Requesting reviews from Girgias and the RMs 😄
This is for consistency with other
*_close()functions that have become obsolete when migrating from resources to objects.